Skip to content

Conversation

@lynzrand
Copy link
Collaborator

@lynzrand lynzrand commented Dec 2, 2025

Summary

Closes #1274.

This PR fixes a missing feature in RR, where --verbose should let the build system print the command executed before executing.

Metadata

  • Tests added/updated for bug fixes or new features
  • Compatible with Windows/Linux/macOS

@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 2, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/moon/src/rr_build/dry_run.rs  39% smaller
  crates/moon/src/cli/run.rs  33% smaller
  crates/moon/src/run/runtest.rs  29% smaller
  crates/moon/src/cli/build.rs  0% smaller
  crates/moon/src/cli/bundle.rs  0% smaller
  crates/moon/src/cli/check.rs  0% smaller
  crates/moon/src/cli/doc.rs  0% smaller
  crates/moon/src/cli/test.rs  0% smaller
  crates/moon/src/rr_build/mod.rs  0% smaller

@lynzrand lynzrand requested a review from Yu-zh December 2, 2025 10:16
Copy link
Contributor

@Yu-zh Yu-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some parity tests fail because moon test -v doesn't print the executed command in legacy. I think current behavior is more desirable. Maybe we can switch to RR first and then just promote?

@lynzrand
Copy link
Collaborator Author

lynzrand commented Dec 3, 2025

wait. legacy doesn't print the test commands? IIRC they do, but maybe that's on stderr... maybe all verbose stuff are all on stderr, I'll recheck.

@lynzrand lynzrand requested a review from Yu-zh December 3, 2025 03:41
@lynzrand
Copy link
Collaborator Author

lynzrand commented Dec 3, 2025

Yes, moved them to stderr. Now it should be fine, I guess?

@Yu-zh Yu-zh enabled auto-merge December 3, 2025 03:56
@Yu-zh Yu-zh merged commit 1487d30 into main Dec 3, 2025
13 of 14 checks passed
@Yu-zh Yu-zh deleted the rynco/verbose-rr branch December 3, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve --verbose flag to display running commands and disable progress bar

3 participants