Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

Use standard github user in gitconfig #160

Closed
ungoldman opened this issue Mar 19, 2016 · 3 comments
Closed

Use standard github user in gitconfig #160

ungoldman opened this issue Mar 19, 2016 · 3 comments

Comments

@ungoldman
Copy link
Member

This has been bugging me since the early days but I figured it was too tiny a nitpick to bring up, but since development is at a standstill, now's the perfect time!

A standard for storing github user information already existed before this project, all the way back in 2008.

git config --global github.user defunkt

https://github.com/blog/180-local-github-config

I think we should use that instead of git config --global git.username to avoid unnecessary duplication of the same info in .gitconfig files the world over.

@beaugunderson
Copy link
Member

makes total sense, should probably be filed against github-current-user though:

https://github.com/beaugunderson/github-current-user/blob/master/github-current-user.js#L14

@ungoldman
Copy link
Member Author

👍 will do

@ungoldman
Copy link
Member Author

Thanks @beaugunderson! Bumped github-current-user so both forms are now supported. Some extra googling tells me both forms are out there in abundance, the former one a bit moreso.

  • "git config --global github.user": About 2,140 results
  • "git config --global user.username": About 2,690 results

¯_(ツ)_/¯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants