Skip to content
This repository has been archived by the owner on Jul 11, 2019. It is now read-only.

Added command aliases and leaveall command #114

Merged
merged 4 commits into from
May 4, 2015

Conversation

misspokeycat
Copy link
Contributor

Added two new commands: /leaveall (which also can be called with /wcall or /partall) which leaves all channels except friends, and /alias to resolve #107 .
Command aliases work by using /alias <name of alias> <command to execute> and are called by /<name of alias>. Aliases are stored locally using leveldb.

@ungoldman
Copy link
Member

Thanks @pokemonmegaman! Looks like a very clean implementation to me.

One question: is there a convention for listing and removing aliases we can add as well?

@misspokeycat
Copy link
Contributor Author

It might not be a bad idea just to implement a /help command for listing all commands. As for deleting commands, maybe /rmalias <name of alias>?

@ungoldman
Copy link
Member

@pokemonmegaman both those ideas sound good to me. I hunted around a bit and couldn't find any great conventions for removing an alias in IRC clients. 👍

@misspokeycat
Copy link
Contributor Author

for listing commands, we should have a way of adding messages that only show up locally, because we don't want to send our list of aliases to the rest of the server (that would be annoying). that being said, we really should externalize all the commands into another file, and it would be nice if we could add in descriptions for each one of the commands so we can more easily create /help

@ungoldman
Copy link
Member

@pokemonmegaman just merged a commit from @bcomnes refactoring commands a bit, can you rebase please? 😁

@misspokeycat
Copy link
Contributor Author

Yep, that can certainly be done.

@misspokeycat
Copy link
Contributor Author

Alright, should be good now.

ungoldman added a commit that referenced this pull request May 4, 2015
Added command aliases and leaveall command
@ungoldman ungoldman merged commit 209b6f0 into moose-team:master May 4, 2015
@ungoldman
Copy link
Member

@pokemonmegaman 👍

@tunnckoCore
Copy link
Contributor

yeaaah! looks great :) 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add /alias command
3 participants