Float precision in NanoAOD production#1
Open
moritzmolch wants to merge 2 commits intoCMSSW_10_6_Xfrom
Open
Conversation
moritzmolch
force-pushed
the
fix-nanoaod-float-precision
branch
from
04a8451 to
465911e
Compare
moritzmolch
pushed a commit
that referenced
this pull request
Apr 2, 2023
…_fix_withpuppiproducerfix Make photon protection for existing weights an option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The float precision of some variables - especially some generator-level variables - is not sufficient for a MC production with some modified physics parameters.
For a four-vector some default values seem to be defined, at least according to this snippet:
cmssw/PhysicsTools/NanoAOD/python/common_cff.py
Line 43 in 04a8451
These values are:
precision=10precision=-1precision=12It has to be checked if the following variables are affected by this issue. If necessary the float precision has to be increased:
GenParticlecollection, especially electrons, muons, tau leptons and Higgs bosonsMETcollection/collections (not only pt and phi but also the covariance matrix elements)