Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosa.DeviceDriver: clean up pointless types + other minor changes #1201

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

AnErrupTion
Copy link
Member

This PR focuses on cleaning up pointless and/or unused types in the Mosa.DeviceDriver project. The following changes were done:

  • Removed X86System since it was only initializing ISABus
  • Removed GenericHostBridgeController and IHostBridgeController since they were only used for the 2nd ACPI reset method, except it never worked anyway

In addition, the following changes were also done:

  • Updated the copyright year to 2024
  • Updated the assembly version in Directory.Build.props to 2.6.0.0
  • Improved the StringBuilder implementation
  • Implemented String.Format() to fix non-working string interpolation in the kernel
  • Implemented Char.IsAsciiDigit() as a shortcut to Char.IsDigit()
  • Removed DataBlock.this[] since it was not only unused but also ambiguous (what data type should/would it return?)

@AnErrupTion AnErrupTion self-assigned this Mar 9, 2024
@tgiphil tgiphil merged commit f73cdf1 into mosa:master Mar 9, 2024
67 checks passed
@AnErrupTion AnErrupTion deleted the devicedriver-cleanup branch March 9, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants