-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mosa.Utility.Launcher: bug fixes and behavioral changes #1217
Merged
AnErrupTion
merged 5 commits into
mosa:master
from
SartoxSoftware:launcher-improvements
Apr 20, 2024
Merged
Mosa.Utility.Launcher: bug fixes and behavioral changes #1217
AnErrupTion
merged 5 commits into
mosa:master
from
SartoxSoftware:launcher-improvements
Apr 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AnErrupTion <[email protected]>
tgiphil
requested changes
Apr 12, 2024
tgiphil
requested changes
Apr 13, 2024
Signed-off-by: AnErrupTion <[email protected]>
Signed-off-by: AnErrupTion <[email protected]>
tgiphil
previously requested changes
Apr 15, 2024
Signed-off-by: AnErrupTion <[email protected]>
charsleysa
approved these changes
Apr 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AnErrupTion please update branch with latest master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR focuses on bug fixes and general behavioral changes around Mosa.Utility.Launcher, alongside a few minor features. Here's what been changed:
Demos
folder instead of the console launcherDemos/Console
directory which contains scripts that use the console launcher instead of the GUI one/bin
, which is simply incorrectEmulator.SVGA
has been renamed toEmulator.Graphics
Emulator.Acceleration
, which currently enables hardware acceleration (WHPX on Windows, HVF on macOS, and KVM on Linux) for QEMUBaseLauncher.Quote()
method. Instead, string interpolation is used at all times and when instead a StringBuilder is present, strings are appended directly to it instead of concatenation to decrease any potential memory allocationsBaseLauncher.NullOrEmpty()
method because it was only used once, and it was trivial to implement anywayBaseLauncher.GetResource(string)
method now throws if a manifest resource isn't foundBuilder.Build()
method, theStopwatch.Start()
method is called instead ofStopwatch.StartNew()
because else it wouldn't start the instantiatedStopwatch
, but instead it'd create a new one and discard it immediatelyBuilder.Build()
method no longer checks ifMosaSettings.TemporaryFolder
andMosaSettings.ImageFolder
exist before creating them, becauseDirectory.CreateDirectory()
already does that. Furthermore, it'll create any subdirectories, removing the need for creatingMosaSettings.TemporaryFolder
SimpleTCP
class, incrementations and decrementations of the volatilelines
field have been replaced withInterlocked.Increment()
andInterlocked.Decrement()
respectivelyStarter.IsSucccessful
property has been renamed toStarter.IsSuccessful
Starter
class, thelockObject
field has been introduced to avoid locking usingthis