Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Update packages & Explorer bug fix #1242

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Conversation

tgiphil
Copy link
Member

@tgiphil tgiphil commented Oct 19, 2024

No description provided.

- Fixed Explorer tool / Emit binary
@tgiphil tgiphil self-assigned this Oct 19, 2024
@tgiphil tgiphil added the Bug label Oct 19, 2024
@tgiphil tgiphil added this to the 2.6 Release milestone Oct 19, 2024
@@ -467,6 +467,11 @@ private void CompileAll()
if (Compiler == null)
return;

if (MosaSettings.EmitBinary & !Directory.Exists(MosaSettings.DefaultFolder))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you forgot an ampersand here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

charsleysa
charsleysa previously approved these changes Oct 19, 2024
Copy link
Member

@charsleysa charsleysa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charsleysa charsleysa self-requested a review October 19, 2024 07:54
@charsleysa charsleysa dismissed their stale review October 19, 2024 07:54

Missed error

- Fixed Explorer tool / Emit binary
Copy link
Member

@AnErrupTion AnErrupTion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnErrupTion AnErrupTion merged commit 74cb9d6 into mosa:master Oct 19, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants