Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created GC SafePoint #1245

Merged
merged 9 commits into from
Oct 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Source/Data/IR-Instructions.json
Original file line number Diff line number Diff line change
Expand Up @@ -1494,7 +1494,7 @@
"IgnoreInstructionBasicBlockTargets": "true"
},
{
"Name": "GCPoint",
"Name": "SafePoint",
"FamilyName": "IR",
"ResultCount": 0,
"OperandCount": 0,
Expand Down
2 changes: 1 addition & 1 deletion Source/Mosa.Compiler.Framework/Compiler.cs
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ public sealed class Compiler
new DeadBlockStage(),
new AdvancedBlockOrderingStage(),

//new PreciseGCStage(),
new SafePointStage(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the stage actually operational? If so, why wasn't it enabled before?


new CodeGenerationStage(),
mosaSettings.EmitBinary ? new ProtectedRegionLayoutStage() : null,
Expand Down
2 changes: 1 addition & 1 deletion Source/Mosa.Compiler.Framework/IR.cs
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ public static class IR
public static readonly BaseInstruction Truncate64x32 = new Truncate64x32();
public static readonly BaseInstruction TryEnd = new TryEnd();
public static readonly BaseInstruction TryStart = new TryStart();
public static readonly BaseInstruction GCPoint = new GCPoint();
public static readonly BaseInstruction SafePoint = new SafePoint();
public static readonly BaseInstruction Rethrow = new Rethrow();
public static readonly BaseInstruction GetVirtualFunctionPtr = new GetVirtualFunctionPtr();
public static readonly BaseInstruction MemoryCopy = new MemoryCopy();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
namespace Mosa.Compiler.Framework.Instructions;

/// <summary>
/// GCPoint
/// SafePoint
/// </summary>
public sealed class GCPoint : BaseIRInstruction
public sealed class SafePoint : BaseIRInstruction
{
public GCPoint()
public SafePoint()
: base(0, 0)
{
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
namespace Mosa.Compiler.Framework.Stages;

/// <summary>
/// This stage determines were object references are located in code.
/// This stage inserts the GC safe points.
/// </summary>
public class PreciseGCStage : BaseMethodCompilerStage
public class SafePointStage : BaseMethodCompilerStage
{
private TraceLog trace;

Expand Down
Loading