Fix: parked domains blank because CSP frame-ancestors blocks the masked-forward iframe - #14
Merged
Merged
Conversation
Masked-forwarded parked domains (Porkbun frameset, e.g. moshscript.com) iframe moshcoding.com/?dn=<self>, but the CSP frame-ancestors only listed the domains in FRAME_ANCESTORS, so any domain not hand-added there was blocked by the browser and rendered blank. The framed request carries its own ?dn, so trust it to iframe just its own tenant page — new parked domains now work without editing FRAME_ANCESTORS each time. 'self' + the env list still apply; the dn is hostname-validated before being added. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why moshscript.com fails
moshscript.com(and any masked-forwarded parked domain) serves a Porkbun frameset that iframeshttps://moshcoding.com/?dn=moshscript.com. But moshcoding.com sendscontent-security-policy: frame-ancestors 'self' https://moshcode.sh …— moshscript.com isn't in the list, so the browser blocks the frame and the page renders blank. It's a CSP block, not a server error (the tenant page itself returns 200).Fix
Middleware now auto-adds the
?dn=<domain>being rendered (and itswww.) toframe-ancestors. The framed request carries its own?dn, so we trust it to iframe just its own tenant page. New parked domains work without hand-editingFRAME_ANCESTORSfor each one.'self'+ the env list still apply; the dn is hostname-validated first.Verified (local)
?dn=moshscript.com→frame-ancestors 'self' https://moshcode.sh https://moshscript.com https://www.moshscript.comdn→ unchanged ('self' https://moshcode.sh)dn(evil domain") → not injected (validation rejects it)Also works as an immediate hotfix without deploying this: set
FRAME_ANCESTORS = https://moshcode.sh https://www.moshcode.sh https://moshscript.com https://www.moshscript.comin Railway.🤖 Generated with Claude Code