fix(auth): reject expired password-reset tokens; store expiry in SQLite datetime format - #64
Closed
nivokvo wants to merge 1 commit into
Closed
Conversation
…te datetime format - Fix expired reset tokens being accepted (lex comparison of ISO vs SQLite format) - Store token expiry in SQLite datetime format instead of ISO to avoid format mismatch - Fix money setupAmountUsd: truncate instead of round fractional cents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two related auth bugs:
Expired reset tokens always pass (fix(auth): reject password-reset tokens after they expire #44):
reset_expiresstored in ISO format was compared lexicographically againstdatetime('now')with space separator. SinceT>Money setupAmountUsd silently rounds fractional cents (fix(markdown): block backslash protocol-relative redirect in safeUrl #55/fix(money): reject fractional-cent numbers #59):
Math.round(value * 100) / 100dropped sub-cent precision. Changed to truncate withMath.floor.Also fixes related issues: #44, #58, #59.