chore(ci): define a test script so the workflow runs the suite - #67
Merged
Conversation
.github/workflows/test.yml only runs `bun run test` when package.json defines a "test" script, and otherwise prints "No test script defined — skipping". No such script existed, so every green run to date was green because nothing ran: the 25 tests under tests/ were never executed in CI. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/test.ymlgates on atestscript:No such script existed, so every green run to date was green because nothing ran — the 25 tests under
tests/have never executed in CI. Recent master runs finishing in ~20s are checkout +bun installand nothing else.Adds
"test": "bun test tests/". Scoped totests/rather than a barebun testso the runner doesn't wander intonode_modules.Verification
Locally,
bun run test→ 25 pass / 0 fail. The CI run on this PR is the real check: its test step should now report 25 tests instead of the skip message, and take longer than the ~20s no-op runs.bun.lockpins only the root package name, not its version, so the recent v0.2.0 bump doesn't affectbun install --frozen-lockfile.🤖 Generated with Claude Code