fix(test): align setup amount test with fractional-cent rejection - #81
Merged
Conversation
PR #59 made the numeric path of setupAmountUsd reject values finer than a cent, but left the assertion that 2.345 rounds to 2.35 — the exact behavior it removed. That assertion has failed on master ever since, so every PR opened since #59 shows a red test check. Assert the numeric path on a value it actually accepts, and add the regression coverage issue #54 asked for (1.234 and 0.004) that #59 described but never landed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vu1nz Security Review0 finding(s) in PR #? No security issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
masterhas been red since #59, and it is what is blocking #80 (and every other open PR).#59 made the numeric path of
setupAmountUsdreject values finer than a cent, but left this assertion in place:That asserts the rounding behavior #59 deliberately removed, so
setupAmountUsd accepts ordinary positive dollar amountshas failed on every run since. The failure is unrelated to whatever PR happens to be open — it just shows up on all of them.This PR fixes the test, not the implementation. The implementation is correct: I swept all 2,000,000 cent-precision values from
$0.01–$20,000against theNumber.EPSILONguard and found zero false rejections, while2.345,1.234and0.005are all correctly rejected.Changes
2.35) instead of one it now rejects.1.234and0.004. fix(money): reject fractional-cent numbers #59's description promised these but only touchedlib/coinpay.ts, so they never landed.Tests
bun test tests/on this branch — 125 pass, 0 fail (was 124 pass, 1 fail).🤖 Generated with Claude Code