fix: check limit in loop additional to pageSize to avoid google rate … #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…limit exeed - pageSize not working proper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…limit exeed - pageSize not working proper
If I execute gtrace it takes a while and then I get
2023/04/24 08:44:19 list traces: rpc error: code = ResourceExhausted desc = Quota exceeded for quota metric 'Read requests (free)' and limit 'Read requests (free) per minute' of service 'cloudtrace.googleapis.com' for consumer 'project_number:xxxx'.
error details: name = ErrorInfo reason = RATE_LIMIT_EXCEEDED domain = googleapis.com metadata = map[consumer:projects/xxxx quota_limit:ReadRequestsPerMinutePerProject quota_limit_value:300 quota_location:global quota_metric:cloudtrace.googleapis.com/read_requests service:cloudtrace.googleapis.com]
error details: name = Help desc = Request a higher quota limit. url = https://cloud.google.com/docs/quota#requesting_higher_quota
Looks like pageSize is dysfunctional. I added an additional check for limits.