Conversation
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
|
Warning Rate limit exceeded@Prafulrakhade has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 9 minutes and 21 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughReplaced ossrh repository block in Changes
Sequence Diagram(s)(Skipped — changes are configuration and a version bump; no runtime/control-flow changes to visualize.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
artifacts/pom.xml (1)
48-48: Renaming repository ID is safe—no codebase references exist outside pom.xml.Verification confirms that the
ossrhID is referenced only withinartifacts/pom.xml(lines 48, 60, 64). No external configuration files, CI/CD workflows, or Maven settings files in the codebase reference this ID. Renaming tosonatype-centralor similar would be safe and improve clarity, though it remains optional if you prefer to maintain the historical ID name for consistency with external user configurations.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
artifacts/pom.xml(1 hunks)
🔇 Additional comments (2)
artifacts/pom.xml (2)
59-66: I need to verify the correct Maven Central release endpoint. The snapshot URL appears in documentation but both endpoints returned 404. Let me search for the correct release deployment method.Based on the web search results, I can now provide a comprehensive rewritten review comment.
The publisher API endpoint (
https://central.sonatype.com/api/v1/publisher/upload) is documented and used for uploading bundles, and the snapshot repository URL (https://central.sonatype.com/repository/maven-snapshots/) is the correct endpoint for Maven snapshot deployments.The 404 responses from the curl test are expected behavior—requests to the API must be authenticated via a user token header. Unauthenticated requests to these endpoints will return authentication errors rather than being reachable without credentials.
However, there is a structural concern: the
<repository>element (line 65) is typically used for release artifacts, but the/api/v1/publisherendpoint is designed for POST requests to manage deployments rather than standard Maven repository PUT deployments. Using/api/v1/publisherin the<repository>URL field may not work with standard Maven deploy plugins expecting Maven 2 repository structure.For standard Maven deployments:
- Snapshots to
/repository/maven-snapshots/(line 61) is correct- Releases should use a proper Maven 2 repository endpoint structure, not the publisher API
Verify that the release deployment method is compatible with your build tool and authentication strategy. If using the central-publishing-maven-plugin or similar, consult its documentation for the correct URL configuration. If using standard Maven deploy, the publisher API endpoint requires different handling (upload, validate, then publish via separate API calls).
48-55: Configuration verified—Sonatype endpoints are correct for 2025.Both repository endpoints are valid and recommended:
- Snapshot repository:
https://central.sonatype.com/repository/maven-snapshots/is correct- Publisher endpoint:
https://central.sonatype.com/api/v1/publisheris the valid Central Portal Publisher API baseThe "ossrh" ID is legacy naming but remains functional for Central Portal configurations. No changes required.
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
Signed-off-by: Prafulrakhade <prafulrakhade02@gmail.com>
Summary by CodeRabbit