Skip to content

Conversation

@GOKULRAJ136
Copy link
Contributor

@GOKULRAJ136 GOKULRAJ136 commented Jan 9, 2026

Summary by CodeRabbit

  • Localization
    • Added validation messages for bulk upload operations in Arabic, English, Spanish, French, Hindi, Kannada, and Tamil. Users will now see localized error messages when required fields (operation, table name, and file) are missing during bulk data uploads.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 9, 2026

Walkthrough

This pull request adds validation message translations across seven language i18n files. Each file introduces three required-field messages (operation.required, tableName.required, file.required) under either center-level or bulkUpload-level validation schemas.

Changes

Cohort / File(s) Summary
Arabic center validations
artifacts/src/i18n/admin-i18n-bundle/i18n/ara.json
Adds center.validationMessages with three required-field messages for operation, tableName, and file
Bulk upload validations
artifacts/src/i18n/admin-i18n-bundle/i18n/eng.json, es.json, fra.json, hin.json, kan.json, tam.json
Each file introduces bulkUpload.validationMessages block with localized required-field messages for operation, tableName, and file validation

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Seven languages now speak with grace,
Validation messages find their place,
Required fields no longer hide—
From Arabic to Tamil's tide,
The bulk uploads are dignified! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding validation error messages for bulk upload operations across multiple i18n JSON files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 548e83b and 74a3935.

📒 Files selected for processing (7)
  • artifacts/src/i18n/admin-i18n-bundle/i18n/ara.json
  • artifacts/src/i18n/admin-i18n-bundle/i18n/eng.json
  • artifacts/src/i18n/admin-i18n-bundle/i18n/es.json
  • artifacts/src/i18n/admin-i18n-bundle/i18n/fra.json
  • artifacts/src/i18n/admin-i18n-bundle/i18n/hin.json
  • artifacts/src/i18n/admin-i18n-bundle/i18n/kan.json
  • artifacts/src/i18n/admin-i18n-bundle/i18n/tam.json
🔇 Additional comments (7)
artifacts/src/i18n/admin-i18n-bundle/i18n/hin.json (1)

784-794: bulkUpload.validationMessages structure looks consistent; please verify key-path + Hindi wording

The nested { operation|tableName|file: { required: ... } } format matches the existing *.validationMessages.<field>.required pattern used elsewhere in this bundle, which should integrate cleanly.

Two quick checks before merge:

  • Ensure the UI is wired to read bulkUpload.validationMessages.<field>.required (vs expecting flat "operation.required" keys).
  • Please have a Hindi language owner confirm terminology (“operation” → “कार्य”) aligns with the field label/context in the Bulk Upload screen.
artifacts/src/i18n/admin-i18n-bundle/i18n/eng.json (1)

666-676: LGTM; just confirm the consuming code uses this nested required shape

Messages are consistent with existing English copy (“… is required”) and the nesting matches other validationMessages sections.

Please verify the form/validator resolves bulkUpload.validationMessages.<field>.required (and not a flat "operation.required" key).

artifacts/src/i18n/admin-i18n-bundle/i18n/es.json (1)

708-718: Structure matches other locales; please sanity-check Spanish phrasing consistency

The new bulkUpload.validationMessages.<field>.required entries are correctly structured and placed.

Before merge, please:

  • confirm the UI resolves bulkUpload.validationMessages.<field>.required; and
  • have a Spanish locale owner confirm preferred phrasing (e.g., “es requerido” vs “es obligatorio/a”) for consistency across the product.
artifacts/src/i18n/admin-i18n-bundle/i18n/tam.json (1)

792-802: Good addition; please confirm Tamil copy for tableName and key-path usage

The bulkUpload.validationMessages.<field>.required block is well-formed and aligned with the bundle’s validation message structure.

Please verify:

  • the UI reads bulkUpload.validationMessages.<field>.required; and
  • a Tamil reviewer confirms the intended meaning for tableName.required (current string reads closer to “Table required” than “Table name required”).
artifacts/src/i18n/admin-i18n-bundle/i18n/fra.json (1)

924-934: LGTM! Validation messages properly added.

The French validation messages for bulk upload are correctly structured and translated. The three required-field messages (operation, tableName, file) are concise and follow the existing validation message patterns in the file.

artifacts/src/i18n/admin-i18n-bundle/i18n/kan.json (1)

791-801: LGTM! Validation messages properly added.

The Kannada validation messages for bulk upload are correctly structured and localized. The three required-field messages follow the same pattern as other locale files in this PR, maintaining consistency across the i18n bundle.

artifacts/src/i18n/admin-i18n-bundle/i18n/ara.json (1)

665-675: LGTM! Validation messages properly added.

The Arabic validation messages for bulk upload are correctly structured and localized. The implementation is consistent with the other locale files (fra.json, kan.json) in this PR, ensuring uniform validation message support across all supported languages.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant