-
Notifications
You must be signed in to change notification settings - Fork 60
[ES-2778] remove usage of csrf token form cookies #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughPostman collection scripts changed: CSRF token extraction now reads the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@postman-collection/eSignet` Signup.postman_collection.json:
- Around line 133-141: The test script under the "generate CSRF token" step
currently reads the token from cookies via pm.cookies.get("XSRF-TOKEN") and sets
it with pm.environment.set("csrf_token", token); change this to read the token
from the JSON response body (use pm.response.json() and the same JSON property
used elsewhere, e.g. "csrf_token" or "csrfToken") and set the environment
variable with pm.environment.set("csrf_token", <json-token>), and apply the same
change to the other occurrence noted (lines 350-358) so downstream requests use
the JSON-token approach instead of cookies.
Signed-off-by: Sachin Rana <[email protected]>
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Summary by CodeRabbit
Bug Fixes
Tests / Chores
✏️ Tip: You can customize this high-level summary in your review settings.