-
Notifications
You must be signed in to change notification settings - Fork 155
[ES-2777] Always show configuration through actuator/env with some key/values sanitized #1608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
36 changes: 36 additions & 0 deletions
36
esignet-core/src/main/java/io/mosip/esignet/core/config/ActuatorSanitizationConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
| */ | ||
| package io.mosip.esignet.core.config; | ||
|
|
||
| import org.springframework.beans.factory.annotation.Value; | ||
| import org.springframework.boot.actuate.endpoint.SanitizableData; | ||
| import org.springframework.boot.actuate.endpoint.SanitizingFunction; | ||
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Locale; | ||
|
|
||
| /** | ||
| * Custom sanitization rules for Spring Boot Actuator endpoints (e.g. /actuator/env). | ||
| * Any property whose key matches the configured patterns will have its value masked. | ||
| */ | ||
| @Configuration | ||
| public class ActuatorSanitizationConfig implements SanitizingFunction { | ||
|
|
||
| @Value("#{${mosip.esignet.actuator.sanitize.key.endsWith:{'password','secret','key','token','vcap_services','sun.java.command'}}}") | ||
| private List<String> keysToBeSanitizedEndsWith; | ||
|
|
||
| @Value("#{${mosip.esignet.actuator.sanitize.key.contains:{'credentials'}}}") | ||
| private List<String> keysToBeSanitizedContains; | ||
|
|
||
| @Override | ||
| public SanitizableData apply(SanitizableData data) { | ||
| String key = data.getKey().toLowerCase(Locale.ROOT); | ||
| if (keysToBeSanitizedEndsWith.stream().anyMatch(key::endsWith) | ||
| || keysToBeSanitizedContains.stream().anyMatch(key::contains)) return data.withSanitizedValue(); | ||
| return data; | ||
| } | ||
| } | ||
71 changes: 71 additions & 0 deletions
71
esignet-core/src/test/java/io/mosip/esignet/core/config/ActuatorSanitizationConfigTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * This Source Code Form is subject to the terms of the Mozilla Public | ||
| * License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| * file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
| */ | ||
| package io.mosip.esignet.core.config; | ||
|
|
||
| import org.junit.jupiter.api.BeforeEach; | ||
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.boot.actuate.endpoint.SanitizableData; | ||
| import org.springframework.test.util.ReflectionTestUtils; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertSame; | ||
| import static org.mockito.Mockito.*; | ||
|
|
||
| class ActuatorSanitizationConfigTest { | ||
|
|
||
| private ActuatorSanitizationConfig sanitizingFunction; | ||
|
|
||
| @BeforeEach | ||
| void setUp() { | ||
| sanitizingFunction = new ActuatorSanitizationConfig(); | ||
| ReflectionTestUtils.setField(sanitizingFunction, "keysToBeSanitizedEndsWith", List.of("password", "secret")); | ||
| ReflectionTestUtils.setField(sanitizingFunction, "keysToBeSanitizedContains", List.of("credentials")); | ||
| } | ||
|
|
||
| @Test | ||
| void test_sanitizingFunction_endMatch_thenSanitized() { | ||
| SanitizableData data = mock(SanitizableData.class); | ||
| SanitizableData sanitizedData = mock(SanitizableData.class); | ||
|
|
||
| when(data.getKey()).thenReturn("db.password"); | ||
| when(data.withSanitizedValue()).thenReturn(sanitizedData); | ||
|
|
||
| SanitizableData result = sanitizingFunction.apply(data); | ||
|
|
||
| assertSame(sanitizedData, result); | ||
| verify(data).withSanitizedValue(); | ||
| verify(data, atLeastOnce()).getKey(); | ||
| } | ||
|
|
||
| @Test | ||
| void test_sanitizingFunction_containsMatch_thenSanitized() { | ||
| SanitizableData data = mock(SanitizableData.class); | ||
| SanitizableData sanitizedData = mock(SanitizableData.class); | ||
|
|
||
| when(data.getKey()).thenReturn("API_CREDENTIALS_ID"); | ||
| when(data.withSanitizedValue()).thenReturn(sanitizedData); | ||
|
|
||
| SanitizableData result = sanitizingFunction.apply(data); | ||
|
|
||
| assertSame(sanitizedData, result); | ||
| verify(data).withSanitizedValue(); | ||
| verify(data, atLeastOnce()).getKey(); | ||
| } | ||
|
|
||
| @Test | ||
| void test_sanitizingFunction_noMatch_thenOriginalData() { | ||
| SanitizableData data = mock(SanitizableData.class); | ||
|
|
||
| when(data.getKey()).thenReturn("application.name"); | ||
|
|
||
| SanitizableData result = sanitizingFunction.apply(data); | ||
|
|
||
| assertSame(data, result); | ||
| verify(data, never()).withSanitizedValue(); | ||
| verify(data, atLeastOnce()).getKey(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.