Skip to content

Conversation

@gk-XL7
Copy link
Contributor

@gk-XL7 gk-XL7 commented Jan 23, 2026

Summary by CodeRabbit

  • Style
    • Refined form input styling and spacing for improved visual consistency.
    • Adjusted info icon sizing for better visual alignment.
    • Optimized border styling for form input elements.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: GurukiranP <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Walkthrough

This PR contains three distinct modifications: a dependency version bump for the JSON form builder package, CSS styling refinements to form input boxes (removing RTL-specific rules and adjusting padding and borders), and a minor SVG icon size adjustment in the ClaimDetails component.

Changes

Cohort / File(s) Summary
Dependency Version Update
oidc-ui/package.json
@mosip/json-form-builder bumped from ^0.1.1-beta.0 to ^0.1.1-beta.1
Styling Refinements
oidc-ui/src/App.css
Removed RTL-specific styling for date input; adjusted .input_box padding from 0.65em 1em to 0.65em; added !important to border rule for increased specificity
Icon Sizing
oidc-ui/src/components/ClaimDetails.js
SVG info icon dimensions updated from 15px × 14px to 16px × 15px

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • ase-101
  • Prafulrakhade

Poem

🐰 A little bump, some styles refined,
Icons polished, RTL left behind,
Form boxes nestled, borders held tight,
With !important, everything's just right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'ES-2699 few UI fixes.' is vague and non-descriptive, using the generic term 'few UI fixes' without specifying what was actually fixed. Replace the vague 'few UI fixes' with specific details about the changes, such as 'ES-2699 Update dependency version, adjust CSS styling, and refine SVG icon dimensions'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
oidc-ui/src/App.css (1)

651-669: Preserve error/focus border states despite !important.

With border: ... !important on Line 657, the .error and :focus border colors in the same block no longer take effect, so validation and focus cues can disappear.

🐛 Proposed fix (keep base !important, re-enable overrides)
     .input_box {
       display: flex;
       align-items: center;
       width: 100%;
       margin: 0.25em 0 0.4em;
       padding: 0.65em;
       border: 1.5px solid `#e5e7eb` !important;
       border-radius: 0.5em;
       background-color: `#fff`;
       overflow: hidden;

       &.error {
-        border-color: `#fe6b6b`;
+        border-color: `#fe6b6b` !important;
         border-width: 1.75px;
       }

       &:focus {
-        border-color: `#80bdff`;
+        border-color: `#80bdff` !important;
         outline: 0;
       }
     }

@ase-101 ase-101 merged commit 1e1937a into mosip:develop Jan 23, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants