[ES-2798] added testcase to increase the sonarqube coverage#1621
[ES-2798] added testcase to increase the sonarqube coverage#1621KashiwalHarsh wants to merge 2 commits intomosip:developfrom
Conversation
Signed-off-by: Harsh Kashiwal <[email protected]>
WalkthroughAdds new unit tests (ActionTest, expanded AuthorizationServiceTest, and others), removes several unused imports, and changes exception classes: Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| } | ||
|
|
||
| @Test | ||
| public void testInvalidRequestException_constructorAndGetErrorCode() { |
There was a problem hiding this comment.
This testcase adds no value and has no relation to DpopValidation.
| } | ||
|
|
||
| @Test | ||
| void clientDetailCreateRequestV3_constructorWithNullAdditionalConfig_shouldSetNullAdditionalConfig() { |
There was a problem hiding this comment.
This testcase also adds no value. Check if we are using its constructor anywhere, if not then just remove the constructor.
Signed-off-by: Harsh Kashiwal <[email protected]>
Summary by CodeRabbit
Tests
Chores
Refactor