ES-2748 - Updated description for eSignet test cases#1623
ES-2748 - Updated description for eSignet test cases#1623prathmeshj12 wants to merge 2 commits intomosip:developfrom
Conversation
Signed-off-by: Prathmesh Jadhav <prathmesh.j@cyberpwn.com>
Signed-off-by: Prathmesh Jadhav <prathmesh.j@cyberpwn.com>
WalkthroughConsolidates CSRF token fetching to a single early execution point in the test runner, adds database cleanup queries for policy_group and partner deletion, introduces a new UserInfo test workflow for the Consent No Capture flow, updates multiple test configuration descriptions for clarity, and migrates UserInfo test templates to a restructured directory. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In
`@api-test/src/main/resources/esignet/OTPAuthFactorFlow/ConsentNoCapture/UserinfoConsentNoCapture/UserInfoConsentNoCapture.yml`:
- Around line 10-11: This file duplicates templates in the old
"UserinfoConsentNoCapture" folder; either remove the outdated directory or move
this YAML into the PascalCase "UserInfoConsentNoCapture" directory and update
its inputTemplate/outputTemplate references to use the
"UserInfoConsentNoCapture/UserInfoConsentNoCapture" and
"UserInfoConsentNoCapture/UserInfoConsentNoCaptureResult" paths respectively so
only the PascalCase folder remains and no duplicate configurations exist.
In
`@api-test/src/main/resources/esignet/OTPAuthFactorFlow/ConsentNoCapture/UserInfoConsentNoCapture/UserInfoConsentNoCapture.yml`:
- Around line 1-15: Remove the misnamed duplicate directory
"UserinfoConsentNoCapture" (lowercase i) and its YAML/test files so only the
correctly named "UserInfoConsentNoCapture" remains; ensure the single remaining
test configuration retains the uniqueIdentifier
TC_ESignet_UserInfoConsentNoCapture_01 and continues to reference the
input/output templates at
esignet/OTPAuthFactorFlow/ConsentNoCapture/UserInfoConsentNoCapture/UserInfoConsentNoCapture
and ...UserInfoConsentNoCaptureResult to avoid duplicate registration/conflicts
during test discovery.
...net/OTPAuthFactorFlow/ConsentNoCapture/UserinfoConsentNoCapture/UserInfoConsentNoCapture.yml
Show resolved
Hide resolved
...net/OTPAuthFactorFlow/ConsentNoCapture/UserInfoConsentNoCapture/UserInfoConsentNoCapture.yml
Show resolved
Hide resolved
| description: Validate user info retrieval with verified claims for Consent No Capture flow | ||
| role: resident | ||
| restMethod: get | ||
| checkErrorsOnlyInResponse: true |
There was a problem hiding this comment.
Instead use checkStatusCodeOnlyInResponse
Summary by CodeRabbit
Tests
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.