Skip to content

[MOSIP-43983] Sonar profile addition #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajapandi1234 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[MOSIP-43983] Sonar profile addition #1655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 31 additions & 22 deletions authentication/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,27 +454,36 @@
</plugins>
</build>

<profiles>
<profile>
<id>sonar</id>
<build>
<plugins>
<plugin>
<groupId>org.sonarsource.scanner.maven</groupId>
<artifactId>sonar-maven-plugin</artifactId>
<version>${maven.sonar.version}</version>
<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>sonar</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>
<profiles>
<profile>
<id>sonar</id>
<properties>
<sonar.sources>.</sonar.sources>
<sonar.inclusions>src/main/java/**,src/main/resources/**</sonar.inclusions>
<sonar.exclusions>${sonar.coverage.exclusions}</sonar.exclusions>
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
</properties>
<activation>
<activeByDefault>false</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.sonarsource.scanner.maven</groupId>
<artifactId>sonar-maven-plugin</artifactId>
<version>${maven.sonar.plugin.version}</version>
Copy link

@coderabbitai coderabbitai bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Critical: Property name mismatch—plugin version will not resolve.

Line 474 references ${maven.sonar.plugin.version}, but the property defined at line 126 is ${maven.sonar.version}. This mismatch will cause Maven to fail at build time when attempting to resolve the sonar-maven-plugin version.

Apply this diff to fix the property reference:

                    <plugin>
                        <groupId>org.sonarsource.scanner.maven</groupId>
                        <artifactId>sonar-maven-plugin</artifactId>
-                       <version>${maven.sonar.plugin.version}</version>
+                       <version>${maven.sonar.version}</version>
                        <executions>

Alternatively, if maven.sonar.plugin.version is intended to be a separate property for the sonar plugin specifically, define it at line 126 in the properties section.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<version>${maven.sonar.plugin.version}</version>
<plugin>
<groupId>org.sonarsource.scanner.maven</groupId>
<artifactId>sonar-maven-plugin</artifactId>
<version>${maven.sonar.version}</version>
<executions>
🤖 Prompt for AI Agents 
In authentication/pom.xml around line 474, the pom references
${maven.sonar.plugin.version} but the properties section defines
${maven.sonar.version}, causing Maven to fail resolving the plugin version; fix
by either updating the plugin reference at line 474 to use
${maven.sonar.version} to match the existing property, or add a new property
maven.sonar.plugin.version in the properties block (near line 126) with the
intended version value so the plugin reference can resolve.

<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>sonar</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>

</project>