Skip to content

MOSIP-44124 - Added placeholder in DB scripts for PMS prefix context task#1879

Merged
mohanachandran-s merged 1 commit intomosip:developfrom
mohanachandran-s:develop
Jan 23, 2026
Merged

MOSIP-44124 - Added placeholder in DB scripts for PMS prefix context task#1879
mohanachandran-s merged 1 commit intomosip:developfrom
mohanachandran-s:develop

Conversation

@mohanachandran-s
Copy link
Contributor

@mohanachandran-s mohanachandran-s commented Jan 23, 2026

MOSIP-44124 - Added placeholder in DB scripts for PMS prefix context task

Summary by CodeRabbit

  • Chores
    • Enhanced database test infrastructure with improved SQL batch file configuration handling to support additional placeholder substitution in query processing.

✏️ Tip: You can customize this high-level summary in your review settings.

…task

Signed-off-by: Mohanachandran S <mohanachandran.s@technoforte.co.in>
@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Walkthrough

The change adds a new placeholder substitution in the database query execution logic. SQL batch file lines now replace ${runContext} with BaseTestCase.runContext alongside the existing ${currentModule} replacement during query processing.

Changes

Cohort / File(s) Summary
Placeholder Substitution Enhancement
apitest-commons/src/main/java/io/mosip/testrig/apirig/dbaccess/DBManager.java
Added ${runContext} placeholder substitution in SQL batch query processing, replacing it with BaseTestCase.runContext value alongside existing ${currentModule} replacement

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A whisker-twitch and one line grows,
The context flows where placeholder goes,
${runContext} now takes its place,
Batch queries dance at quickened pace! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title references MOSIP-44124 and mentions adding a placeholder in DB scripts for PMS prefix context, which directly aligns with the code change that adds ${runContext} placeholder substitution in database script processing.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mohanachandran-s mohanachandran-s merged commit f1fdb86 into mosip:develop Jan 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants