Revert "[MOSIP-44324] Corrected ng2-pdf-viewer version"#248
Revert "[MOSIP-44324] Corrected ng2-pdf-viewer version"#248mayuradesh merged 1 commit intomosip:developfrom
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This reverts commit ea0f4f1. Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
6b76aca to
5d072a6
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pre-registration-ui/package.json`:
- Line 43: The revert introducing "ng2-pdf-viewer": "^5.3.3" breaks builds on
this repo (Angular 7.2.0); restore the tested safe version by changing the
dependency back to "ng2-pdf-viewer": "^3.0.8" (as done in PR `#247`) or, if you
truly need a newer ng2-pdf-viewer, first upgrade the Angular framework and build
toolchain (Angular 7.2.0 -> supported version) so pdfjs-dist 2.x+ is compatible
before bumping the ng2-pdf-viewer version.
Reverts #247
Summary by CodeRabbit