Skip to content

Revert "[MOSIP-44324] Corrected ng2-pdf-viewer version"#248

Merged
mayuradesh merged 1 commit intomosip:developfrom
GOKULRAJ136:revert-247-pdf-dev
Feb 3, 2026
Merged

Revert "[MOSIP-44324] Corrected ng2-pdf-viewer version"#248
mayuradesh merged 1 commit intomosip:developfrom
GOKULRAJ136:revert-247-pdf-dev

Conversation

@GOKULRAJ136
Copy link
Contributor

@GOKULRAJ136 GOKULRAJ136 commented Feb 3, 2026

Reverts #247

Summary by CodeRabbit

  • Chores
    • Updated PDF viewer component to the latest compatible version for improved stability and performance.

@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

Walkthrough

The ng2-pdf-viewer dependency in the pre-registration UI package was updated from version 3.0.8 to version range ^5.3.3, representing a significant version bump that expands compatible versions.

Changes

Cohort / File(s) Summary
Dependency Version Update
pre-registration-ui/package.json
Updated ng2-pdf-viewer from pinned version 3.0.8 to version range ^5.3.3, allowing patch and minor updates within the 5.x series.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A PDF viewer hops to new heights,
From three to five in one grand leap,
The package dance brings new delights,
Compatibility ranges run deep.
No single version holds its sway,
The caret lets updates play! 📄✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: reverting a previous commit that corrected the ng2-pdf-viewer version, which matches the raw_summary showing the version change from 3.0.8 to ^5.3.3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

This reverts commit ea0f4f1.

Signed-off-by: GOKULRAJ136 <110164849+GOKULRAJ136@users.noreply.github.com>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@pre-registration-ui/package.json`:
- Line 43: The revert introducing "ng2-pdf-viewer": "^5.3.3" breaks builds on
this repo (Angular 7.2.0); restore the tested safe version by changing the
dependency back to "ng2-pdf-viewer": "^3.0.8" (as done in PR `#247`) or, if you
truly need a newer ng2-pdf-viewer, first upgrade the Angular framework and build
toolchain (Angular 7.2.0 -> supported version) so pdfjs-dist 2.x+ is compatible
before bumping the ng2-pdf-viewer version.

@mayuradesh mayuradesh merged commit abcb0b6 into mosip:develop Feb 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants