-
Notifications
You must be signed in to change notification settings - Fork 52
[ON HOLD] feat: auto detection of model encoding types #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
TABULAR_AUTO
,LANGUAGE_AUTO
AUTO
: Before the PR, it means the same asTABULAR_AUTO
, now it is like the union ofTABULAR_AUTO
andLANGUAGE_AUTO
LANGUAGE_AUTO
-> auto detectLANGUAGE_NUMERIC
,LANGUAGE_DATETIME
,LANGUAGE_TEXT
TABULAR_AUTO
-> "highly-unique categorical columns" (categorical columns that has >100 rows and more than 5% of rows contain unique values) will be detected asTABULAR_CHARACTER
AUTO
-> "highly-unique categorical columns" will be detected asTABULAR_CHARACTER
when lengths of all rows are the same. Otherwise it will beLANGUAGE_TEXT
*_AUTO
encoding types)*_model_configuration
inSourceTableConfig
before auto detectionSourceTableConfig
strictly (i.e., including*_model_configuration
) after auto detection is doneSourceTable
always has strict validationtest_auto_detect_encoding_types_and_pk
,test__auto_detect_encoding_type
,test__auto_detect_primary_key
Code refactoring:
DataTable
classMisc / Changes that are not directly related to the requirements:
CustomBaseModel
inmostlyai/sdk/_data/metadata_objects.py
so that the classes can be initialized without using aliases/camelCase field names.MostlyAI.train()
: allow data to be fed as the first unnamed argumenttest_execution_plan.py
.DS_Store
to.gitignore