Skip to content

feat: format phone number in user info synchronization #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polyglot-k merged 1 commit into from
Aug 12, 2025
Merged

feat: format phone number in user info synchronization #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/life/mosu/mosuserver/application/profile/ProfileService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import life.mosu.mosuserver.domain.user.repository.UserJpaRepository;
import life.mosu.mosuserver.global.exception.CustomRuntimeException;
import life.mosu.mosuserver.global.exception.ErrorCode;
import life.mosu.mosuserver.global.util.PhoneNumberUtil;
import life.mosu.mosuserver.presentation.profile.dto.EditProfileRequest;
import life.mosu.mosuserver.presentation.profile.dto.ProfileDetailResponse;
import life.mosu.mosuserver.presentation.profile.dto.SignUpProfileRequest;
Expand Down Expand Up @@ -76,7 +77,7 @@ private void checkIfProfileExistsForUser(UserJpaEntity user) {
private void syncUserInfoFromProfile(UserJpaEntity user, SignUpProfileRequest request) {
if (user.isMosuUser()) {
user.updateUserInfo(Gender.fromName(request.gender()), request.userName(),
request.phoneNumber(), request.birth());
PhoneNumberUtil.formatPhoneNumber(request.phoneNumber()), request.birth());
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Aug 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The phone number from SignUpProfileRequest might contain hyphens (e.g., "010-1234-5678"). Storing phone numbers with optional hyphens can lead to data inconsistency. It's best practice to normalize the phone number by removing hyphens before storing it. This ensures a canonical format in the database for UserJpaEntity.

Note: This change will make the phone number format in UserJpaEntity inconsistent with ProfileJpaEntity, as ProfileJpaEntity is created using request.toEntity() which uses the raw phone number. You should consider normalizing the phone number for ProfileJpaEntity as well for data consistency across the system, perhaps by modifying SignUpProfileRequest.toEntity().

Suggested change
PhoneNumberUtil.formatPhoneNumber(request.phoneNumber()), request.birth());
PhoneNumberUtil.formatPhoneNumber(request.phoneNumber().replaceAll("-", "")), request.birth());

}
}
}
Expand Down