chore: remove final legacy cleanup items#78
Merged
Conversation
…ck branches All downstream consumers now use ConnectionProfile / to_driver_kwargs(). Removes get_connection_string_template, get_connection_string_params, get_connection_kwargs, format_connection_string from BaseDBConnection, the isinstance(ConnectionProfile) guard and legacy path from BaseIbisConnection.connect_default(), and the isinstance dispatch from IcebergConnectionBase.connect_default(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Upstream mountainash-settings now enforces SecretStr typing via validate_assignment=True, making the isinstance guard redundant. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #78 +/- ##
===========================================
+ Coverage 54.79% 55.82% +1.03%
===========================================
Files 51 51
Lines 2617 2556 -61
Branches 288 270 -18
===========================================
- Hits 1434 1427 -7
+ Misses 1074 1021 -53
+ Partials 109 108 -1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseDBConnection(get_connection_string_template,get_connection_string_params,get_connection_kwargs,format_connection_string) and legacy fallback branches in Ibis/Icebergconnect_default()isinstance(pw, SecretStr)guard withpw is not Nonecheck inConnectionProfile.to_connection_string(), now that upstreammountainash-settingsenforcesSecretStrtyping viavalidate_assignment=TrueCloses the final two actionable items from the legacy-cleanup backlog.
Test Plan
hatch run test:test-quick— 441 passed, 6 skipped🤖 Generated with Claude Code