feat: add exasol, impala, materialize, risingwave, druid dialects to IbisBackend#85
Merged
Merged
Conversation
Registers SingleStoreDB as the 15th supported dialect. MySQL-compatible connection model with added driver protocol selector (mysql/http/https) and local_infile parameter. No adapter needed — all params map directly via driver_key. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Registers 5 remaining SQL-based ibis backends, bringing the total to 20 supported dialects. All follow the established DialectSpec + BackendDescriptor pattern with no custom adapters needed. Notable: Druid uses ENDPOINT_PATH (not PATH) to avoid collision with the system PATH environment variable in pydantic settings. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the 5 remaining SQL-based ibis backends, completing full coverage of all server-based ibis dialects:
clusterparam for streaming SQLENDPOINT_PATH+SCHEMEparamsBrings total dialect count from 15 → 20. All use KWARGS connection mode with no custom adapters.
Note: Druid uses
ENDPOINT_PATHinstead ofPATHto avoid collision with the systemPATHenvironment variable in pydantic settings.Stacks on: #84 (SingleStoreDB dialect)
Changes
core/constants.py— 5 new entries in provider type, backend, and prefix enumscore/settings/{exasol,impala,materialize,risingwave,druid}.py— Settings classescore/settings/__init__.py— Wire up exportsbackends/ibis/dialects/_registry.py— 5 connection builders + DialectSpec entriespyproject.toml— 5 optional extrastests/— 33 new unit tests across 5 test files, registry count 15 → 20Test plan
🤖 Generated with Claude Code