feat(secrets): add secrets resolution to SettingsParameters#40
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Address three findings: - kwargs on cache-hit now resolved in apply_runtime_overrides() - Drop SecretsResolvingSource wrapper; use post-construction instance field resolution to avoid model_config class-level bleed - Registry uses write-once semantics with explicit replace/clear API Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ruction Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…he-hit paths Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #40 +/- ##
==========================================
Coverage ? 96.90%
==========================================
Files ? 36
Lines ? 938
Branches ? 123
==========================================
Hits ? 909
Misses ? 16
Partials ? 13 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Summary
secret:prefix resolution to SettingsParameters via a pluggable resolver registrysecrets_providerstructural parameter on SettingsParameters controls whether and how secrets are resolvedreplace_secrets_resolver()andclear_secrets_registry()for controlled useChanges
src/mountainash_settings/secrets/— registry, dict-walker, instance-walkersecrets_providerfield (structural, in hash/eq/merge/create/to_dict)SecretsResolver,register_secrets_resolver,get_secrets_resolver,replace_secrets_resolver,clear_secrets_registryDesign decisions
secrets_provideris structural (affects cache key) because different providers produce different field valuesSecretsResolvingSourcewrapper — post-construction resolution avoids class-levelmodel_configbleed (per adversarial review)ValueErroron duplicate registrationTest plan
🤖 Generated with Claude Code