Skip to content

Remove auth subtree (moved to mountainash-auth-client)#45

Merged
discreteds merged 6 commits into
developfrom
feature/auth-extraction-cleanup
May 27, 2026
Merged

Remove auth subtree (moved to mountainash-auth-client)#45
discreteds merged 6 commits into
developfrom
feature/auth-extraction-cleanup

Conversation

@discreteds

Copy link
Copy Markdown
Member

Summary

  • Deletes auth/ subtree entirely (14 files) — auth schemas now live in mountainash-auth-client
  • Removes _auth_kwargs() from Profile — replaced by standalone auth_kwargs() in mountainash-auth-client
  • Updates invariants.py to import AuthSpec from mountainash-auth-client
  • Clean break: no deprecation shim, all auth re-exports removed from __init__.py

Dependencies

  • Requires mountainash-auth-client (test dependency only)
  • Must merge AFTER mountainash-wearables PR (wearables must switch to auth-client imports before settings drops re-exports)

Test plan

  • 447 tests pass locally (0 failures)
  • No remaining from mountainash_settings.auth imports in src/ or tests/
  • Profile no longer has _auth_kwargs method
  • Auth types no longer exported from mountainash_settings package

🤖 Generated with Claude Code

- Removes test_auth_modes_are_authspec method from invariants
- Disables import of AuthSpec from mountainash_auth_client
- Simplifies profile validation logic for auth modes
[tests]: Add test cases for pydantic assignment validation

- Add tests for secret string wrapping on direct attribute assignment
- Add tests for enum coercion on direct attribute assignment
- Add tests for after validator transformations on direct attribute assignment
- Ensure validate_assignment remains enabled on base and profile classes
- Replaces auth client imports with stubs in test files
- Introduces lightweight auth model stubs for test isolation
- Removes test files dependent on external auth client
- Updates test cases to use local stub implementations
@sonarqubecloud

Copy link
Copy Markdown

@discreteds discreteds merged commit 2096c50 into develop May 27, 2026
6 checks passed
@discreteds discreteds deleted the feature/auth-extraction-cleanup branch May 27, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant