Skip to content

Minor fixes to the Helm chart #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

Minor fixes to the Helm chart #202

merged 2 commits into from
May 19, 2025

Conversation

Farfaday
Copy link

Hi,
this MR:

  • add the possibility to set revisionHistoryLimit in the deployment, but keeping the default value to kubernete's default, thus making this change transparent
  • add missing "resources" block into the deployment (defined in values.yaml but missing in the deployment)

Thanks!

@pcallewaert pcallewaert self-assigned this May 13, 2025
@pcallewaert pcallewaert added this to the 2.0 milestone May 13, 2025
pcallewaert
pcallewaert reviewed May 18, 2025
View reviewed changes
Copy link
Contributor

@pcallewaert pcallewaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Can you remove the version bump? I'll create a separate PR to make a new helm chart release, as there is a breaking change in main currently

@Farfaday
Copy link
Author

Hi @pcallewaert
I removed the version Bump :)
Thanks!

@pcallewaert pcallewaert merged commit f5755b9 into movetokube:master May 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcallewaert pcallewaert pcallewaert approved these changes

Assignees

@pcallewaert pcallewaert

Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Farfaday @pcallewaert