generated from moxystudio/react-lib-template
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add NextLink component #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,118 @@ | ||
# react-lib-template | ||
A template that aims to make the implementation of `React` component packages easier and more methodic. | ||
# next-link | ||
|
||
[![NPM version][npm-image]][npm-url] [![Downloads][downloads-image]][npm-url] [![Build Status][build-status-image]][build-status-url] [![Coverage Status][codecov-image]][codecov-url] [![Dependency status][david-dm-image]][david-dm-url] [![Dev Dependency status][david-dm-dev-image]][david-dm-dev-url] | ||
|
||
[npm-url]:https://npmjs.org/package/@moxy/next-link | ||
[downloads-image]:https://img.shields.io/npm/dm/@moxy/next-link.svg | ||
[npm-image]:https://img.shields.io/npm/v/@moxy/next-link.svg | ||
[build-status-url]:https://github.com/moxystudio/next-link/actions | ||
[build-status-image]:https://img.shields.io/github/workflow/status/moxystudio/next-link/Node%20CI/master | ||
[codecov-url]:https://codecov.io/gh/moxystudio/next-link | ||
[codecov-image]:https://img.shields.io/codecov/c/github/moxystudio/next-link/master.svg | ||
[david-dm-url]:https://david-dm.org/moxystudio/next-link | ||
[david-dm-image]:https://img.shields.io/david/moxystudio/next-link.svg | ||
[david-dm-dev-url]:https://david-dm.org/moxystudio/next-link?type=dev | ||
[david-dm-dev-image]:https://img.shields.io/david/dev/moxystudio/next-link.svg | ||
|
||
A wrapper component that uses [next/link](https://nextjs.org/docs/api-reference/next/link) to enable client-side transitions between routes as well as external URLs. | ||
|
||
## Installation | ||
|
||
```sh | ||
$ npm install @moxy/next-link | ||
``` | ||
|
||
This library is written in modern JavaScript and is published in both CommonJS and ES module transpiled variants. If you target older browsers please make sure to transpile accordingly. | ||
|
||
## Motivation | ||
|
||
When using Next.js, we have [next/link](https://nextjs.org/docs/api-reference/next/link) to navigate between client-side routes, but when we need to navigate to external URLs an anchor tag has to be used. | ||
|
||
This component supports both, using `NextLink` we can pass an internal or external URL, using the same component for both. With the `external` prop we specify the type of route and it takes care of the rest for us, rendering the `next/link` or an `<a>` tag, maintaining the same styles between the two. | ||
|
||
## Usage | ||
|
||
This repo serves as the template for the creation of MOXY's base `React` components. To use this, just select `@moxystudio/react-lib-template` as the template when creating a new repo for your new package, and you're all set to start working. | ||
```js | ||
import React from 'react'; | ||
import NextLink from '@moxy/next-link'; | ||
|
||
const MyPage = (props) => ( | ||
<div className="container"> | ||
<NextLink href="/about">About</NextLink> | ||
<NextLink href="/contact">Contact</NextLink> | ||
<NextLink external href="https://moxy.studio">MOXY</NextLink> | ||
</div> | ||
); | ||
|
||
export default MyPage; | ||
``` | ||
|
||
## API | ||
|
||
Besides the following supported props by the `NextLink` component, additional props will be spread to the anchor tag. | ||
|
||
#### href | ||
|
||
Type: `string` | Required: `true` | ||
|
||
The path for an internal or external URL. | ||
|
||
#### children | ||
|
||
Type: `node` | Required: `true` | ||
|
||
What to render inside the component. | ||
|
||
#### className | ||
|
||
Type: `string` | Required: `false` | ||
|
||
A className to apply to the component wrapper. | ||
|
||
#### newTab | ||
|
||
Type: `bool` | Required: `false` | Default: `false` | ||
|
||
If set to true, opens the link in a new tab. | ||
|
||
#### external | ||
|
||
Type: `bool` | Required: `false` | Default: `false` | ||
|
||
If set to *true*, opens an external URL. If set to *false*, navigates to an internal page. | ||
|
||
#### prefetch | ||
|
||
Type: `bool` | Required: `false` | Default: `true` | ||
|
||
Prefetch the page in the background. | ||
|
||
Only available if `external` is set to *false*. Check the [next/link](https://nextjs.org/docs/api-reference/next/link) documentation to learn more. | ||
|
||
#### as | ||
|
||
Type: `string` | Required: `false` | ||
|
||
The path that will be rendered in the browser URL bar. Used for dynamic routes. | ||
|
||
Only available if `external` is set to *false*. Check the [next/link](https://nextjs.org/docs/api-reference/next/link) documentation to learn more. | ||
|
||
#### scroll | ||
|
||
Type: `bool` | Required: `false` | Default: `true` | ||
|
||
Scroll to the top of the page after a navigation. | ||
|
||
Only available if `external` is set to *false*. Check the [next/link](https://nextjs.org/docs/api-reference/next/link) documentation to learn more. | ||
|
||
|
||
## Tests | ||
|
||
This template already includes a `src` folder, with 2 dummy files ready for you to start your work. `NewComponent` is a dummy component, available for demonstration purposes. Just rename `NewComponent.js` and change it according to your needs. An `index.js` for exporting is available as well. Do not forget to update the unit tests and try to reach as much coverage as possible. | ||
```sh | ||
$ npm test | ||
$ npm test -- --watch # during development | ||
``` | ||
|
||
In order to help make proper use of this template, here's a quick checklist with some crucial stuff to have in mind: | ||
## License | ||
|
||
- Remember to change `package.json` name, description, keywords, etc. | ||
- Review the dependencies, removing the unnecessary ones. | ||
- Just to stress this out again: add unit tests and check for a good coverage. The closest to 100%, the better. | ||
- Make sure to update the `README`, documenting the features of your component as best as possible. | ||
Released under the [MIT License](./LICENSE). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,9 @@ | ||
'use strict'; | ||
|
||
const { compose, baseConfig, withRTL } = require('@moxy/jest-config'); | ||
const { compose, baseConfig, withWeb, withRTL } = require('@moxy/jest-config'); | ||
|
||
module.exports = compose( | ||
baseConfig(), | ||
withRTL(), | ||
withWeb(), | ||
); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.