Extra Mutators and tests #3
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I have added in some new mutators (with tests) and begun adding some tests for existing mutators and cast types.
Added
Fixes
__()
resolved this for me.Testing
Further considerations
Faker
or similar in the test suite to generate random values to test with.Add
/Subtract
/Divide
/Exponential
mutators I introduced a behaviour change with additional arguments, compared with how that works with theMultiply
mutator. Those new mutators will apply any subsequent arguments provided (rather than just the first). I'll be honest I'm not 100% it will be needed, I was just wondering on a use case where I might want to potentially want to be passing in a constant and then a unique power. If you'd rather this stick to the behaviour of multiply, reject this and I'll correct accordingly.