Skip to content

[onhold] chore: setup frontend pre commit hook #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[onhold] chore: setup frontend pre commit hook #1161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5b2f883
setup husky & lint-staged
khaledosman Mar 10, 2025
2574e89
unset hooksPath before running pre-commit install
khaledosman Mar 10, 2025
771664b
remove --all-files
khaledosman Mar 10, 2025
308a473
reinstall husky after uv pre-commit
khaledosman Mar 10, 2025
6fea93f
Merge branch 'main' into frontend-pre-commit
khaledosman Mar 11, 2025
eafa81a
Merge branch 'main' into frontend-pre-commit
khaledosman Mar 12, 2025
4ce0d50
remove unnecessary uv pre-commit install
khaledosman Mar 12, 2025
b274e83
Merge branch 'main' into frontend-pre-commit
khaledosman Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ endef

# Launches Lumigator in 'development' mode (all services running locally, code mounted in)
local-up: config-generate-env
uv run pre-commit install
pushd lumigator/frontend && npm i && popd
RAY_ARCH_SUFFIX=$(RAY_ARCH_SUFFIX) ARCH=${ARCH} COMPUTE_TYPE=$(COMPUTE_TYPE) docker compose --env-file "$(CONFIG_BUILD_DIR)/.env" --profile local $(GPU_COMPOSE) $(MODEL_CACHE_COMPOSE) -f $(LOCAL_DOCKERCOMPOSE_FILE) -f $(DEV_DOCKER_COMPOSE_FILE) up --watch --build

local-down: config-generate-env
Expand Down
15 changes: 15 additions & 0 deletions lumigator/frontend/.husky/pre-commit
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

# FRONTEND_DIR="$(dirname "$0")/../lumigator/frontend"

# Run backend linting with pre-commit
echo "Running backend linting..."
uv run pre-commit run

# Run frontend linting with lint-staged
echo "Running frontend lint-staged..."
cd lumigator/frontend
npx lint-staged

echo "✅ Pre-commit checks passed!"
Loading
Loading