remove deprecated react-hot-loader dependency

[dannycolin]

react-hot-loader has been deprecated for years in favour of Fast Refresh. This patch removes it but it doesn't implement Fast Refresh just yet. This is because our bundler (Webpack 4) is also pretty old and we need more clean up and update before we can easily add more modern tools.

So, this patch is only the clean up step. It doesn't remove any user facing feature and it's only a minor inconvenient when in developer mode since you might have to manually refresh the page and/or lose form information when a refresh happens after saving your change in the codebase.

[lotas]

Thanks for removing this. Do you know what's up with the lockfile? Maybe we are using an outdated yarn? All CI tasks failed to install dependencies

[dannycolin]

Thanks for removing this. Do you know what's up with the lockfile? Maybe we are using an outdated yarn? All CI tasks failed to install dependencies

I wonder if the lockfile isn't simply corrupted because I used npm to install the packages on my local environment.

[dannycolin]

I wonder if the lockfile isn't simply corrupted because I used npm to install the packages on my local environment.

Looks like the lockfile was indeed corrupted but there's another yarn issue now because many of our dependencies are outdated. Sidenote, it strangely works fine if you use npm instead of yarn.

I'll see if it's worth fixing it this week. If not, we (well me) have to consider a more drastic approach.