Add bookmarks for individual results - #398
Draft
davehunt wants to merge 1 commit into
Draft
Conversation
|
Deploy preview for firefox-performance-dashboard ready! Built with commit d49bd7a https://deploy-preview-398--firefox-performance-dashboard.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
=======================================
Coverage 84.75% 84.75%
=======================================
Files 14 14
Lines 328 328
Branches 47 47
=======================================
Hits 278 278
Misses 45 45
Partials 5 5 Continue to review full report at Codecov.
|
Contributor
|
I'm trying to make it not reload when the anchor is added, but without success. I'll investigate more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently had the need to direct someone to results that were quite a way down the page, and thought it would be handy to have a way to link directly to a chart. I suppose I could have sent them to the subtest view, but not all charts have this. This patch is an attempt to add a named anchor and a linked icon for convenient copying, but it's not working as intended. When clicking, I get a page reload, and when using the full URL doesn't work because content loads asynchronously.
@airimovici do you have any ideas how I could make this work?