Run UI tests on API 34 #3723
Open
Run UI tests on API 34 #3723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronMT
reviewed
Jul 21, 2025
| @@ -32,11 +34,21 @@ class ContextMenusTest { | |||
| dispatcher = AndroidAssetDispatcher() | |||
| start() | |||
| } | |||
|
|
|||
| // Prevent the System UI from reading the clipboard content | |||
| if (Build.VERSION.SDK_INT == Build.VERSION_CODES.UPSIDE_DOWN_CAKE) { | |||
There was a problem hiding this comment.
Should these checks be >= if not because we don't know, we should add a comment as the known tested version up to Android 14
There was a problem hiding this comment.
I'm not sure, since we didn't verify all APIs and it was only required for 34 we are only checking for it.
| fun clickSystemHomeScreenShortcutAddButton() { | ||
| when (Build.VERSION.SDK_INT) { | ||
| in Build.VERSION_CODES.O..Build.VERSION_CODES.R -> clickAddAutomaticallyButton() | ||
| in Build.VERSION_CODES.S..Build.VERSION_CODES.UPSIDE_DOWN_CAKE -> clickAddToHomeScreenButton() |
There was a problem hiding this comment.
I would just add a comment stating that this is up to Android 14 as a known tested version unless we know Android 15 is the same, we could just extend to VANILLA_ICE_CREAM
AndiAJ
force-pushed
the
API34
branch
2 times, most recently
from
25053b5 to
dfb912a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
All UI tests successfully passed 2x on Firebase ✅
Pull Request checklist