Skip to content

hack: Keep 125.0.1 as a major version #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhearsum merged 1 commit into from
Apr 17, 2024
Merged

hack: Keep 125.0.1 as a major version #1430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions api/src/shipit_api/admin/product_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,16 +455,24 @@ def get_release_history(
continue

# skip all releases which don't fit into product category
if product_category is ProductCategory.MAJOR and (
release_version.patch_number is not None or release_version.beta_number is not None or release_version.is_esr
):
continue
# short term hack: 125.0.1 is a major release. we should replace this with
# https://github.com/mozilla-releng/mozilla-version/pull/109
if not (release_version.major_number != "125" and release_version.patch_number != "1"):
if product_category is ProductCategory.MAJOR and (
release_version.patch_number is not None or release_version.beta_number is not None or release_version.is_esr
):
continue

elif product_category is ProductCategory.DEVELOPMENT and (release_version.beta_number is None or release_version.is_esr):
continue

elif product_category is ProductCategory.STABILITY and (release_version.beta_number is not None or release_version.patch_number is None):
continue
elif product_category is ProductCategory.STABILITY:
# short term hack: 125.0.1 is a major release. we should replace this with
# https://github.com/mozilla-releng/mozilla-version/pull/109
if not (release_version.major_number == "125" and release_version.patch_number == "1"):
continue
if release_version.beta_number is not None or release_version.patch_number is None:
continue

history_version = release.version
if history_version.endswith("esr"):
Expand Down