add selenium tests #19
Conversation
|
@mcav please if you have time to review this PR and add it to the repo, we will have some tests that can be run. |
|
This is a fine start, thanks. There's an important issue we should address before these are going to be useful, though: As you discovered, the element selectors are horrible, horrible, horrible (due to there not being any accessible class names on elements), and they may not even be deterministic. That will very quickly render these tests obsolete. I've noted this in issue #21. You're welcome to merge this if you'd like (for the sake of getting the files in the repo), but I have a feeling they will all break (if they haven't already) due to xpath selector changes very quickly until we fix #21. I can make that a priority right after this sprint. |
|
Thanks @mcav! Yeah the way to find the selectors is an issue, but thought that asking for an id for each element was a big workload for you and if we can use xpath or css selector in the meantime could work while there are not big changes in the website. It is true that tests fail easily due to the changes in xpath, that is why I did not want to add them to CI yet, but only to the repo to be run manually, so we (QA) could work on the same scenario to create more tests (although we have to change the selectors from time to time) but this would help us to improve the code and coverage. I will close this PR since I am working on a better version of the tests following the Page Object pattern. That way the elements are defined in one file and not in the tests which will help to maintain them in case of changes. And also it makes the tests to be more easy to read and run faster :) Thanks! |
No description provided.