Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ports exposed in docker compose configurable #113

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Make ports exposed in docker compose configurable #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d7a59f
Don't expose unnecessary ports in docker-compose
relud Dec 18, 2023
510d6dc
Apply suggestions from code review
relud Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ services:
extends:
service: base
ports:
- "8000:8000"
- "${EXPOSE_ELIOT_PORT:-8000}:8000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you set this in .env, then make run doesn't really work. Is it possible to set this in .env for the local dev environment, but not the devcontainer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then make run doesn't really work

how so? it still runs eliot, just exposed on a different port

depends_on:
- fakesentry
- statsd
Expand Down Expand Up @@ -55,15 +55,11 @@ services:
context: docker/images/fakesentry
image: local/eliot_fakesentry
ports:
- "8090:8090"
relud marked this conversation as resolved.
Show resolved Hide resolved
- "${EXPOSE_SENTRY_PORT:-8090}:8090"
relud marked this conversation as resolved.
Show resolved Hide resolved
command: run --host 0.0.0.0 --port 8090

# https://hub.docker.com/r/hopsoft/graphite-statsd/
statsd:
image: hopsoft/graphite-statsd:latest
ports:
- "8081:80"
relud marked this conversation as resolved.
Show resolved Hide resolved
- "2003-2004:2003-2004"
- "2023-2024:2023-2024"
- "8125:8125/udp"
- "8126:8126"
- "${EXPOSE_GRAFANA_PORT:-8081}:80"