Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-1870734: update eliot to python 3.11 #114

Merged
merged 1 commit into from
Dec 19, 2023
Merged

bug-1870734: update eliot to python 3.11 #114

merged 1 commit into from
Dec 19, 2023

Conversation

relud
Copy link
Member

@relud relud commented Dec 18, 2023

No description provided.

@relud relud requested a review from a team December 18, 2023 23:08
@@ -445,7 +445,7 @@ def test_nested_directories(cm_client, tmpdir):
"num_unhandled_errors": "0",
"event": ["1", "256", "0", "'xul__4byte.symc'"],
"event_flags": ["<flags.CREATE: 256>"],
"flags_list": "'flags.CREATE'",
"flags_list": "'256'",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum serialization behavior changed in 3.11 https://docs.python.org/3/whatsnew/3.11.html#enum

@@ -43,6 +43,8 @@ addopts = "-rsxX --showlocals --tb=native -p no:cacheprovider --import-mode=impo
# Transform all warnings into errors
filterwarnings = [
"error",
# Falcon currently uses cgi which is going away in python 3.13
"ignore:'cgi' is deprecated and slated for removal in Python 3.13:DeprecationWarning",
Copy link
Member Author

@relud relud Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Falcon is planning to fix this in version 4 falconry/falcon#2066, but it supports python 3.11 as of Falcon 3.1.1

For now python 3.13 isn't coming out for another 11 months, and @willkg is investigating switching to another micro-framework such as flask or fastapi bug 1870735

Copy link

@vytas7 vytas7 Dec 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @relud, yes, we will release either 4.0 or another microrelease to make the framework work on the latest versions of CPython and PyPy. (We already support 3.12 incl binary wheels.)
I understand the wish to consolidate around a smaller number of frameworks, but in the case you reconsider, we are always open to feedback wrt "some pitfalls along the way" 😉

Copy link
Contributor

@willkg willkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@@ -1,4 +1,4 @@
FROM python:3.10.8-alpine3.16@sha256:d17cfece24cb5d0432b37c138f307a19dd461b88aded1fc6981ef5c997c74de1
FROM python:3.11.7-alpine3.19@sha256:84271da1cd297b01dd4706e01e7789b08b54a5a512c0e3fcaf11c902640f5ebd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep forgetting to ditch alpine here and everywhere else we use Kent. I updated the Kent suggested Dockerfile to switch to bookworm (Debian 12):

https://github.com/willkg/kent#running-in-a-docker-container

We can keep this and I can toss an item in my todo list to switch kent to use bookworm.

@relud relud merged commit bb8d0f4 into main Dec 19, 2023
1 check passed
@relud relud deleted the bug-1870734-py311 branch December 19, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants