-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug-1870734: update eliot to python 3.11 #114
Conversation
@@ -445,7 +445,7 @@ def test_nested_directories(cm_client, tmpdir): | |||
"num_unhandled_errors": "0", | |||
"event": ["1", "256", "0", "'xul__4byte.symc'"], | |||
"event_flags": ["<flags.CREATE: 256>"], | |||
"flags_list": "'flags.CREATE'", | |||
"flags_list": "'256'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enum serialization behavior changed in 3.11 https://docs.python.org/3/whatsnew/3.11.html#enum
@@ -43,6 +43,8 @@ addopts = "-rsxX --showlocals --tb=native -p no:cacheprovider --import-mode=impo | |||
# Transform all warnings into errors | |||
filterwarnings = [ | |||
"error", | |||
# Falcon currently uses cgi which is going away in python 3.13 | |||
"ignore:'cgi' is deprecated and slated for removal in Python 3.13:DeprecationWarning", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Falcon is planning to fix this in version 4 falconry/falcon#2066, but it supports python 3.11 as of Falcon 3.1.1
For now python 3.13 isn't coming out for another 11 months, and @willkg is investigating switching to another micro-framework such as flask or fastapi bug 1870735
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @relud, yes, we will release either 4.0 or another microrelease to make the framework work on the latest versions of CPython and PyPy. (We already support 3.12 incl binary wheels.)
I understand the wish to consolidate around a smaller number of frameworks, but in the case you reconsider, we are always open to feedback wrt "some pitfalls along the way" 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this!
@@ -1,4 +1,4 @@ | |||
FROM python:3.10.8-alpine3.16@sha256:d17cfece24cb5d0432b37c138f307a19dd461b88aded1fc6981ef5c997c74de1 | |||
FROM python:3.11.7-alpine3.19@sha256:84271da1cd297b01dd4706e01e7789b08b54a5a512c0e3fcaf11c902640f5ebd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I keep forgetting to ditch alpine here and everywhere else we use Kent. I updated the Kent suggested Dockerfile to switch to bookworm (Debian 12):
https://github.com/willkg/kent#running-in-a-docker-container
We can keep this and I can toss an item in my todo list to switch kent to use bookworm.
No description provided.