Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug-1862187: Switch Eliot to use PORT for gunicorn #115

Merged
merged 1 commit into from
Dec 20, 2023
Merged

bug-1862187: Switch Eliot to use PORT for gunicorn #115

merged 1 commit into from
Dec 20, 2023

Conversation

relud
Copy link
Member

@relud relud commented Dec 19, 2023

No description provided.

@relud relud requested a review from a team December 19, 2023 23:11
willkg
willkg approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@willkg willkg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our infra sets both ELIOT_GUNICORN_PORT and PORT, so this shouldn't break anything or require an additional change.

https://github.com/mozilla-it/webservices-infra/blob/ec72085a0d6da3dd4902ecb0a5a2a2458a71d14b/symbols/k8s/eliot/templates/configmap.yaml#L9-L13

Thank you for doing this!

@relud relud merged commit 82bcae0 into main Dec 20, 2023
1 check passed
@relud relud deleted the bug-1862187 branch December 20, 2023 02:46
@smarnach
Copy link
Contributor

We could eventually remove ELIOT_GUNICORN_PORT from the Helm chart, but we should only do that once this change is in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willkg willkg willkg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@relud @smarnach @willkg