update python to 3.11.9 #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
willkg
commented
Apr 8, 2024
willkg
commented
- Update Python to 3.11.9
- Update fakesentry to Python 3.11.9 and switch to debian bullseye
- Fix interpreter in sentry-wrap.py
|
The CircleCI pipeline failed because it was still set up as a webhook. It's not required by branch protections. I removed the webhook, but the check status will be there until we update the PR. I'll do that next. |
relud
approved these changes
Apr 9, 2024
bin/sentry-wrap.py
Outdated
|
|
||
| # This Source Code Form is subject to the terms of the Mozilla Public | ||
| # License, v. 2.0. If a copy of the MPL was not distributed with this | ||
| # file, You can obtain one at https://mozilla.org/MPL/2.0/. | ||
|
|
||
| # Wraps a command such that if it fails, an error report is sent to the Sentry service | ||
| # specified by SENTRY_DSN in the environment. | ||
| # specified by ELIOT_SECRET_ELIOT_SECRET_SENTRY_DSN in the environment. |
There was a problem hiding this comment.
seems like a typo here:
Suggested change
| # specified by ELIOT_SECRET_ELIOT_SECRET_SENTRY_DSN in the environment. | |
| # specified by ELIOT_SECRET_SENTRY_DSN in the environment. |
There was a problem hiding this comment.
Boo search-and-replace!
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.