Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: process records in top picks if source field is not available #870

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

gruberb
Copy link
Member

@gruberb gruberb commented Mar 28, 2025

References

Process records also if the source field does not exist inside the Top Picks provider. The current manifest doesn't contain the source field yet. This is a backwards compatible fix, which can be removed after the next successful navigational suggestion job run.

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

@gruberb gruberb requested a review from a team March 28, 2025 17:56
@gruberb gruberb force-pushed the fix-process-top-picks branch from dc15e9e to d42e402 Compare March 28, 2025 18:29
@gruberb gruberb added this pull request to the merge queue Mar 28, 2025
Merged via the queue into main with commit 7d5ba96 Mar 28, 2025
11 checks passed
@gruberb gruberb deleted the fix-process-top-picks branch March 28, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants