Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1892312 - Add recoveredFromBackup to environment schema. #814

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

mikeconley
Copy link
Contributor

Unfortunately, when attempting to run the build scripts to run the tests, I got this error:

 => CACHED [stage-0  2/15] RUN set -eux;     apt-get update;     apt-get install -y --no-install-recommends         ca-certificates         gcc         libc6-dev         wget         ;     dpkgArch="$(dpkg --print-architecture)";     case "${dpkgArch##*-  0.0s
 => CACHED [stage-0  3/15] RUN mkdir -p /usr/share/man/man1 &&     apt-get update -qqy &&     apt-get install -qqy         cmake         diffutils         gcc         g++         jq         make         wget         git         openjdk-11-jdk-headless     0.0s
 => CACHED [stage-0  4/15] RUN cargo install jsonschema-transpiler --version 1.9.0                                                                                                                                                                              0.0s
 => CACHED [stage-0  5/15] RUN git config --global user.email "[email protected]"                                                                                                                                                            0.0s
 => CACHED [stage-0  6/15] RUN git config --global user.name "Mozilla Pipeline Schemas"                                                                                                                                                                         0.0s
 => CACHED [stage-0  7/15] WORKDIR /app                                                                                                                                                                                                                         0.0s
 => CACHED [stage-0  8/15] COPY --from=mozilla/ingestion-sink:latest /app/ingestion-sink/target /app/target                                                                                                                                                     0.0s
 => CACHED [stage-0  9/15] COPY requirements.txt requirements-dev.txt ./                                                                                                                                                                                        0.0s
 => CACHED [stage-0 10/15] RUN pip3 install --upgrade pip setuptools &&     pip3 install -r requirements.txt -r requirements-dev.txt                                                                                                                            0.0s
 => CACHED [stage-0 11/15] COPY pom.xml .                                                                                                                                                                                                                       0.0s
 => CACHED [stage-0 12/15] RUN mvn dependency:copy-dependencies                                                                                                                                                                                                 0.0s
 => CACHED [stage-0 13/15] COPY . /app                                                                                                                                                                                                                          0.0s
 => CACHED [stage-0 14/15] RUN pip3 install .                                                                                                                                                                                                                   0.0s
 => CACHED [stage-0 15/15] RUN mkdir release &&     cd release &&     cmake .. &&     make                                                                                                                                                                      0.0s
 => ERROR exporting to image                                                                                                                                                                                                                                    0.0s
 => => exporting layers                                                                                                                                                                                                                                         0.0s
 => => writing image sha256:cee25823f9058e5260effc2e4979eddbe02a6f46afb9f35626792f5a7f40f604                                                                                                                                                                    0.0s
------
 > exporting to image:
------
ERROR: failed to solve: operating system is not supported

So I'm afraid I haven't been able to run the tests to make sure they still pass.

Checklist for reviewer:

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

@auto-assign auto-assign bot requested a review from scholtzan May 6, 2024 17:49
@BenWu
Copy link
Contributor

BenWu commented Jun 10, 2024

@mikeconley Is this still needed? This has been inactive for a month but I'm guessing it is. We've only received environment.profile.recoveredFromBackup eight times in the past month so not much has been missed.

For the tests, you can try docker build -t mozilla-pipeline-schemas:latest . instead of ./scripts/mps-build, assuming you're using an apple cpu. The script adds --platform=amd64 which doesn't work for me. The tests passed in CI already though so it's fine this time

@mikeconley mikeconley force-pushed the 813_add_recoveredFromBackup branch from 5fdba1b to a7688c0 Compare June 11, 2024 14:07
@mikeconley
Copy link
Contributor Author

Thanks, @BenWu! Yes, using docker build -t mozilla-pipeline-schemas:latest . worked, and I was able to run the tests, which pass. I've also rebased on main.

@mikeconley
Copy link
Contributor Author

And yes, we'd still very much like this!

@BenWu BenWu merged commit fd238de into mozilla-services:main Jun 11, 2024
2 checks passed
dataops-pipeline-schemas added a commit that referenced this pull request Jun 12, 2024
fd238de	2024-06-11 13:31:13 -0400	Bug 1892312 - Add recoveredFromBackup to environment schema. (#814)
akkomar pushed a commit to akkomar/mozilla-pipeline-schemas that referenced this pull request Jun 17, 2024
fd238de	2024-06-11 13:31:13 -0400	Bug 1892312 - Add recoveredFromBackup to environment schema. (mozilla-services#814)
92bed1f	2024-06-07 10:23:01 -0400	Revert "Change creationDate in telemetry.crash to date-time format (mozilla-services#816)" (mozilla-services#817)
a69d990	2024-06-06 16:56:14 -0400	[Bug 1898073] Change creationDate in telemetry.crash to date-time format (mozilla-services#816)
5b92daa	2024-05-16 16:06:14 +0200	Bug 1896975 - Add `signedState` and `signedTypes` for the active theme to the environment schema (mozilla-services#815)
eeea9f5	2024-05-01 13:47:23 -0400	Bug 1875874 - Allow null distro and distroVersion in legacy telemetry (mozilla-services#810)
c3d13ba	2024-03-21 11:39:13 -0700	Bug 1886684 - Add `signedTypes` to the environment schema
5500136	2024-03-13 10:59:38 -0500	[DENG-3022] Support minimum glean schema (mozilla-services#808)
b3dad47	2024-03-04 18:58:19 +0100	Add missing changelog entry for Bug 1751739
98288f4	2024-03-04 18:58:19 +0100	add (optional) session_id & session_count to Glean client info
3c95c42	2024-03-04 09:21:58 -0800	Update remote Docker image version
21636e8	2024-02-14 10:41:17 +0100	Remove metadata from glean.1 schema
5fcb761	2024-02-14 10:41:17 +0100	Always propagate mozPipelineMetadata if non-empty
52119e6	2024-02-12 08:05:28 -0600	Set `json_object_path` for the Glean schema
7d3e33c	2024-02-12 08:05:28 -0600	Define json_object_path in metaschema
30ad83a	2024-02-12 08:05:28 -0600	Add the object type with very shallow restrictions
782eeef	2024-02-02 12:07:47 -0600	Bug 1845596 - Update telemetry event schema json (mozilla-services#804)
7115104	2024-01-18 09:16:58 -0800	Add generated schema for default browser
4abe8e5	2024-01-18 09:16:58 -0800	Add `previous_os_version` to `default-browser-agent/default-browser`.
f0be9dd	2024-01-17 09:07:13 -0800	Bug 1665381 - Added distribution fields to stub installer ping schema
a82bcf7	2024-01-17 09:07:13 -0800	Bug 1665381 - Added distribution fields to stub installer ping schema
7062c74	2024-01-12 09:26:18 -0800	Bug 1874038 - Add environment.os.distro/distroVersion to table schemas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants