Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug 1898073] Change creationDate in telemetry.crash to date-time format #816

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

BenWu
Copy link
Contributor

@BenWu BenWu commented Jun 6, 2024

https://bugzilla.mozilla.org/show_bug.cgi?id=1898073

The java schema validator that we use in the decoder (and these tests) will automatically validate the date-time format. The python validator needs some tweaking but that's only used in this repo's tests AFAIK

Only crash creationDate changed to limit risk

Checklist for reviewer:

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

@auto-assign auto-assign bot requested a review from scholtzan June 6, 2024 16:21
@BenWu BenWu merged commit a69d990 into main Jun 6, 2024
2 checks passed
@BenWu BenWu deleted the benwu/crash-creation-date branch June 6, 2024 20:56
@akkomar
Copy link
Contributor

akkomar commented Jun 7, 2024

This changed type of creation_date column in generated schema to TIMESTAMP and is causing schema generator failure:

[2024-06-07, 03:48:11 UTC] {pod_manager.py:466} INFO - [base] --- /app/validate_schema_evolution/9cab73ff29262e01908ecece70436964343b3f5e_base-revision/telemetry.crash.4.txt
[2024-06-07, 03:48:11 UTC] {pod_manager.py:466} INFO - [base] +++ /app/validate_schema_evolution/355db31e060bcfcdcb3e40970c7407b3e520f1c6_generated-schemas/telemetry.crash.4.txt
[2024-06-07, 03:48:11 UTC] {pod_manager.py:466} INFO - [base] @@ -11,3 +11,3 @@
[2024-06-07, 03:48:11 UTC] {pod_manager.py:466} INFO - [base] root.client_id STRING
[2024-06-07, 03:48:11 UTC] {pod_manager.py:466} INFO - [base] -root.creation_date STRING
[2024-06-07, 03:48:11 UTC] {pod_manager.py:466} INFO - [base] +root.creation_date TIMESTAMP
[2024-06-07, 03:48:11 UTC] {pod_manager.py:466} INFO - [base] root.document_id STRING

BenWu added a commit that referenced this pull request Jun 7, 2024
dataops-pipeline-schemas added a commit that referenced this pull request Jun 7, 2024
92bed1f	2024-06-07 10:23:01 -0400	Revert "Change creationDate in telemetry.crash to date-time format (#816)" (#817)
a69d990	2024-06-06 16:56:14 -0400	[Bug 1898073] Change creationDate in telemetry.crash to date-time format (#816)
akkomar pushed a commit to akkomar/mozilla-pipeline-schemas that referenced this pull request Jun 17, 2024
fd238de	2024-06-11 13:31:13 -0400	Bug 1892312 - Add recoveredFromBackup to environment schema. (mozilla-services#814)
92bed1f	2024-06-07 10:23:01 -0400	Revert "Change creationDate in telemetry.crash to date-time format (mozilla-services#816)" (mozilla-services#817)
a69d990	2024-06-06 16:56:14 -0400	[Bug 1898073] Change creationDate in telemetry.crash to date-time format (mozilla-services#816)
5b92daa	2024-05-16 16:06:14 +0200	Bug 1896975 - Add `signedState` and `signedTypes` for the active theme to the environment schema (mozilla-services#815)
eeea9f5	2024-05-01 13:47:23 -0400	Bug 1875874 - Allow null distro and distroVersion in legacy telemetry (mozilla-services#810)
c3d13ba	2024-03-21 11:39:13 -0700	Bug 1886684 - Add `signedTypes` to the environment schema
5500136	2024-03-13 10:59:38 -0500	[DENG-3022] Support minimum glean schema (mozilla-services#808)
b3dad47	2024-03-04 18:58:19 +0100	Add missing changelog entry for Bug 1751739
98288f4	2024-03-04 18:58:19 +0100	add (optional) session_id & session_count to Glean client info
3c95c42	2024-03-04 09:21:58 -0800	Update remote Docker image version
21636e8	2024-02-14 10:41:17 +0100	Remove metadata from glean.1 schema
5fcb761	2024-02-14 10:41:17 +0100	Always propagate mozPipelineMetadata if non-empty
52119e6	2024-02-12 08:05:28 -0600	Set `json_object_path` for the Glean schema
7d3e33c	2024-02-12 08:05:28 -0600	Define json_object_path in metaschema
30ad83a	2024-02-12 08:05:28 -0600	Add the object type with very shallow restrictions
782eeef	2024-02-02 12:07:47 -0600	Bug 1845596 - Update telemetry event schema json (mozilla-services#804)
7115104	2024-01-18 09:16:58 -0800	Add generated schema for default browser
4abe8e5	2024-01-18 09:16:58 -0800	Add `previous_os_version` to `default-browser-agent/default-browser`.
f0be9dd	2024-01-17 09:07:13 -0800	Bug 1665381 - Added distribution fields to stub installer ping schema
a82bcf7	2024-01-17 09:07:13 -0800	Bug 1665381 - Added distribution fields to stub installer ping schema
7062c74	2024-01-12 09:26:18 -0800	Bug 1874038 - Add environment.os.distro/distroVersion to table schemas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants