Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_client_id and include_info_sections to metaschema #818

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Add include_client_id and include_info_sections to metaschema #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0064c3e
Add `include_client_id` and `include_info_sections` to metaschema
BenWu Jun 12, 2024
338cc0f
Merge branch 'main' into benwu/include-metaschema
BenWu Jul 30, 2024
3b193fc
swap order
BenWu Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions schemas/metadata/metaschema/metaschema.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@
"description": "If present, how many additional entries (beyond two) to skip in x_forwarded_for when performing geoip decoding, useful when submissions are ingested from trusted proxies; if there are fewer entries in x_forwarded_for than (N+1) the last entry is used instead of (N+3)rd-to-last",
"type": "integer"
},
"include_client_id": {
"description": "Glean ping property that determines whether a client id is sent in the ping.",
"type": "boolean"
},
"include_info_sections": {
"description": "Glean ping property that determines whether info sections are sent, e.g. client_info, ping_info.",
"type": "boolean"
},
"json_object_path_regex": {
"description": "The path for which a JSON column will be enforced. This should be a regular expression which is used by the jsonschema-transpiler to match against the fully qualified name of a metric",
"type": "string"
Expand Down
8 changes: 8 additions & 0 deletions templates/metadata/metaschema/metaschema.1.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,14 @@
}
}
},
"include_client_id": {
"type": "boolean",
"description": "Glean ping property that determines whether a client id is sent in the ping."
},
"include_info_sections": {
"type": "boolean",
"description": "Glean ping property that determines whether info sections are sent, e.g. client_info, ping_info."
},
"override_attributes": {
"type": "array",
"description": "Mappings of Pub/Sub attribute names to static values; these are applied in the Decoder immediately before incorporating metadata into the payload, so can be used to overwrite values calculated in the pipeline; a null value will cause the pipeline to drop the named attribute; some attribute names differ from the nested metadata format in BigQuery, so for example you must use \"geo_city\" here in order to manipulate the value that shows up as metadata.geo.city; implemented for bug 1742172",
Expand Down