Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1907663 - Add scale factor fields to gfx #824

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

saschanaz
Copy link
Contributor

Checklist for reviewer:

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

@auto-assign auto-assign bot requested a review from akkomar July 25, 2024 17:32
Copy link
Contributor

@BenWu BenWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do this is by updating the environment schema template here and then running the build instructions in the readme, which. should give the same output. CI is failing because the template doesn't match the output

@saschanaz
Copy link
Contributor Author

Thanks, I should have suspected that there should be a better option than regex 😅 for now I tried manual fix.

@BenWu BenWu merged commit 5fd0d85 into mozilla-services:main Jul 25, 2024
2 checks passed
@BenWu
Copy link
Contributor

BenWu commented Jul 25, 2024

The columns should show up tomorrow. We seem to be getting significant volume already (in the additional_properties column)

@saschanaz saschanaz deleted the scale branch July 25, 2024 21:54
@saschanaz
Copy link
Contributor Author

Thank you!

dataops-pipeline-schemas added a commit that referenced this pull request Jul 26, 2024
5fd0d85	2024-07-25 17:36:47 -0400	Bug 1907663 - Add scale factor fields to gfx (#824)
dcdbfbb	2024-07-25 18:43:08 +0200	Bug 1901263: Add `profileGroupId` to schemas. (#822)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants