Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing windows_ubr to be type string #836

Closed
wants to merge 1 commit into from

Conversation

erchen03
Copy link
Contributor

@erchen03 erchen03 commented Jan 10, 2025

Checklist for reviewer:

For glean changes:

  • Update templates/include/glean/CHANGELOG.md

For modifications to schemas in restricted namespaces (see CODEOWNERS):

@auto-assign auto-assign bot requested a review from akkomar January 10, 2025 16:32
@BenWu
Copy link
Contributor

BenWu commented Jan 10, 2025

We can't trivially change the data type of a field after it's added to the bigquery schema. We would need to do something like windows_ubr2 which would require a client-side release or some special case in ingestion. I'll see if we have some precedent for doing this

@erchen03 erchen03 closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants