feat: create post/put bsos postgres #1911
Open
+117
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taddes
changed the title
taddes
force-pushed
the
feat/create-post-bsos-postgres-STOR-339
branch
2 times, most recently
from
cb05820 to
4bfd8ff
Compare
taddes
changed the title
taddes
force-pushed
the
feat/create-post-bsos-postgres-STOR-339
branch
from
8b7eae1 to
44be220
Compare
Merged
taddes
force-pushed
the
feat/create-post-bsos-postgres-STOR-339
branch
from
44be220 to
c3a4e8a
Compare
chenba
reviewed
Dec 8, 2025
| collection_id, | ||
| collection: params.collection, | ||
| }) | ||
| .await?; |
Collaborator
There was a problem hiding this comment.
This is already called in put_bso.
chenba
reviewed
Dec 8, 2025
| ) -> Result<results::PostBsos, Self::Error> { | ||
| todo!() | ||
| async fn post_bsos(&mut self, params: params::PostBsos) -> DbResult<results::PostBsos> { | ||
| let collection_id = self.get_or_create_collection_id(¶ms.collection).await?; |
Collaborator
There was a problem hiding this comment.
Since we have the collection id here, let's pass it to put_bso instead of repeatedly call get_or_create_collection there.
taddes
force-pushed
the
feat/create-post-bsos-postgres-STOR-339
branch
from
c3a4e8a to
3e37fec
Compare
chenba
reviewed
Dec 8, 2025
| todo!() | ||
| let collection_id = self.get_or_create_collection_id(¶ms.collection).await?; | ||
| let modified = self.timestamp(); | ||
|
|
Collaborator
There was a problem hiding this comment.
Why couldn't we have a quota check here and error out early?
pjenvey
requested changes
Dec 8, 2025
Comment on lines
+482
to
+486
| payload: if bso.payload.is_some() { | ||
| Some(payload) | ||
| } else { | ||
| None | ||
| }, |
Member
There was a problem hiding this comment.
Suggested change
| payload: if bso.payload.is_some() { | |
| Some(payload) | |
| } else { | |
| None | |
| }, | |
| payload: bso.payload.as_deref(), |
Comment on lines
+467
to
+472
| // original required millisecond conversion | ||
| let expiry_ts = SyncTimestamp::from_i64(timestamp + (i64::from(ttl) * 1000))?; | ||
| let modified_ts = SyncTimestamp::from_i64(timestamp)?; | ||
|
|
||
| let expiry_dt = expiry_ts.as_naive_datetime()?; | ||
| let modified_dt = modified_ts.as_naive_datetime()?; |
Member
There was a problem hiding this comment.
I think this is simpler/more explicit going through chrono:
Suggested change
| // original required millisecond conversion | |
| let expiry_ts = SyncTimestamp::from_i64(timestamp + (i64::from(ttl) * 1000))?; | |
| let modified_ts = SyncTimestamp::from_i64(timestamp)?; | |
| let expiry_dt = expiry_ts.as_naive_datetime()?; | |
| let modified_dt = modified_ts.as_naive_datetime()?; | |
| let modified = self.timestamp().as_naive_datetime()?; | |
| let expiry = modified_dt + TimeDelta::seconds(ttl as i64); |
| #[derive(AsChangeset)] | ||
| #[diesel(table_name = bsos)] | ||
| pub struct BsoChangeset<'a> { | ||
| pub sortindex: Option<Option<i32>>, |
Member
There was a problem hiding this comment.
I don't think you're able to actually NULL out sortindex on update
Suggested change
| pub sortindex: Option<Option<i32>>, | |
| pub sortindex: Option<i32>, |
pjenvey
requested changes
Dec 8, 2025
Comment on lines
+487
to
+496
| expiry: if bso.ttl.is_some() { | ||
| Some(expiry_dt) | ||
| } else { | ||
| None | ||
| }, | ||
| modified: if bso.payload.is_some() || bso.sortindex.is_some() { | ||
| Some(modified_dt) | ||
| } else { | ||
| None | ||
| }, |
Member
There was a problem hiding this comment.
nit: you could use map and/or then_some for these
Suggested change
| expiry: if bso.ttl.is_some() { | |
| Some(expiry_dt) | |
| } else { | |
| None | |
| }, | |
| modified: if bso.payload.is_some() || bso.sortindex.is_some() { | |
| Some(modified_dt) | |
| } else { | |
| None | |
| }, | |
| modified: (bso.payload.is_some() || bso.sortindex.is_some()).then_some(modified), | |
| expiry: bso.ttl.map(|_| expiry_dt), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement logic to
putandposttobsostable.Issue(s)
Closes STOR-339.