Bleach Add-on Summary of all HTML #22994

chrstinalin · 2025-01-15T12:49:16Z

Changes NoURLsTranslation to now escape all HTML, on top of stripping any links. Existing HTML is not escaped.

Updating an add-on's summary with HTML will escape the HTML.

Add #ISSUENUM at the top of your PR to an existing open issue in the mozilla/addons repository.
Successfully verified the change locally.
The change is covered by automated tests, or otherwise indicated why doing so is unnecessary/impossible.
Add or update relevant docs reflecting the changes made.

src/olympia/bandwagon/models.py

src/olympia/translations/models.py

chrstinalin added 2 commits January 15, 2025 13:41

Strip all HTML from NoURLsTranslation (namely for Addon summaries)

9d18ce1

docs

88b90bf

chrstinalin marked this pull request as draft January 15, 2025 12:51

chrstinalin added 7 commits January 16, 2025 11:19

tests

86fe836

comment, super

2dbe621

better comments

89ea528

Merge branch 'master' into mozilla#15254-bleach-summary

cc3d4e9

PureTranslationTest

7a07b28

Merge branch 'mozilla#15254-bleach-summary' of https://github.com/chr…

37fae82

…stinalin/addons-server into mozilla#15254-bleach-summary

lint

4dbfb42

chrstinalin marked this pull request as ready for review January 27, 2025 21:06

chrstinalin requested a review from diox January 27, 2025 21:21

diox approved these changes Jan 28, 2025

View reviewed changes

src/olympia/bandwagon/models.py Outdated Show resolved Hide resolved

src/olympia/translations/models.py Outdated Show resolved Hide resolved

comment wording

edf1068

chrstinalin merged commit 0197c75 into mozilla:master Jan 28, 2025
49 checks passed

Provide feedback